disable wheel relocation for aarch builds #7852
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have an ongoing CI failure for the aarch64 builds after #7834, e.g. https://github.com/pytorch/vision/actions/runs/5892600360/job/15982284257
The jobs fail, because we are building on Linux and thus wheel relocation is enabled
vision/packaging/wheel/relocate.py
Lines 16 to 18 in 74f50d9
but aarch64 builds no longer install
auditwheel
:vision/packaging/pre_build_script.sh
Line 14 in 74f50d9
vision/packaging/pre_build_script.sh
Lines 26 to 36 in 74f50d9
There are two possible options here:
aarch wheels don't need relocation. This is the assumption I made in this PR, since that might be what Pre-Script Update for Aarch64 #7834 was about. Thus, I fixed our relocation script to only import
auditwheel
on Linux x86aarch wheels need relocation. That sounds more likely to me. In this case, we can revert the changes I made to
relocate.py
and apply something likecc @seemethere