Skip to content

Conversation

pmeier
Copy link
Collaborator

@pmeier pmeier commented May 31, 2023

Instead of pinning numpy as done in #7639, this PR reuses the pre-install logic that we have in place for Windows for all workflows. Since pip does not suffer from the same issues as easy_install that should be more "future-proof". And take that with a grain of salt, since easy_install is deprecated anyway.

cc @seemethere

@pytorch-bot
Copy link

pytorch-bot bot commented May 31, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/7645

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit 1999593:

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if green

@pmeier pmeier marked this pull request as ready for review May 31, 2023 11:15
@malfet malfet merged commit a6f6387 into pytorch:main May 31, 2023
@github-actions
Copy link

Hey @malfet!

You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

@pmeier pmeier deleted the deps-upfront branch May 31, 2023 14:00
facebook-github-bot pushed a commit that referenced this pull request Jun 14, 2023
Reviewed By: vmoens

Differential Revision: D46724125

fbshipit-source-id: 2ddffb76c90a56f94a671e570349f80029715faa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants