Fix typos and grammar errors #7065
Conversation
There was a problem hiding this comment.
I've reverted all formatting changes in gallery/**/*. I'm in favor of fixing most of them, but we shouldn't do so in this PR. Overall, we now have -284,+281 changed lines. The asymmetry comes from three docstrings where I merged two lines into one. I've highlighted them below.
| for name in val_datasets: | ||
| if name == "kitti": | ||
| # Kitti has different image sizes so we need to individually pad them, we can't batch. | ||
| # Kitti has different image sizes, so we need to individually pad them, we can't batch. |
There was a problem hiding this comment.
I assume this comes from a hard rule that "so" must be preceded by a comma?
This doesn't work too well in practice IMO - but not worth nitpicking.
(I'm biased on this specific example because I think I was the one writing this comment)
There was a problem hiding this comment.
I'm by no means an expert on the English language and thus I trusted the grammar checker here. But indeed, it told me
that "so" must be preceded by a comma
I don't know if this is just hard-coded or if this was a specific hint for the case at hand and in other situations the hint is not displayed.
|
Hey @pmeier! You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py |
pmeier
added
the
other
Summary: * fix typos throughout the code base * fix grammar * revert formatting changes to gallery * revert 'an uXX' * remove 'number of the best' Reviewed By: YosuaMichael Differential Revision: D42500907 fbshipit-source-id: d43295b8dc8f29f7ea89a659f2ca61749ac2b9b8
3 participants
I've run my IDE's spelling and grammar checker on our repository and it found quite a few improvements. With very few exceptions, the only changes happened in the docstrings or in code comments and thus don't affect the functionality at all. The one major exception is the file
https://github.com/pytorch/vision/blob/main/references/depth/stereo/vizualization.py
since it was flagged. I couldn't find the spelling "vizualization" in any dictionary. Thus, I've renamed it to
visualization.pyand fixed all imports of it. This of course should also not effect functionality, but has the potential if I botched the renaming.