Skip to content

Conversation

kit1980
Copy link
Contributor

@kit1980 kit1980 commented Dec 8, 2022

No description provided.

Copy link
Contributor

@datumbox datumbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @kit1980. I left one comment below, let me know what you think.

@kit1980 kit1980 force-pushed the sdym/docstring-args branch from 03b2e60 to 396d6ea Compare December 13, 2022 01:04
@kit1980
Copy link
Contributor Author

kit1980 commented Dec 13, 2022

@datumbox I've updated the PR, please take another look.

Copy link
Contributor

@datumbox datumbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @kit1980.

@datumbox datumbox merged commit 0dceac0 into main Dec 13, 2022
@github-actions
Copy link

Hey @datumbox!

You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

@datumbox datumbox deleted the sdym/docstring-args branch December 13, 2022 08:54
facebook-github-bot pushed a commit that referenced this pull request Dec 16, 2022
Reviewed By: YosuaMichael

Differential Revision: D42046595

fbshipit-source-id: e663b8e9fb45dbdc130f7b714d5808301e59ebe2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants