Skip to content

Conversation

pmeier
Copy link
Collaborator

@pmeier pmeier commented Oct 28, 2022

These are needed since pytorch/pytorch#87577 added to strict annotations. I already pinged them in pytorch/pytorch#87577 (comment)

cc @seemethere

Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would kill to get accurate results of how much time is wasted on type annotations / type checking vs how much time is saved / prevented bugs

Copy link
Contributor

@datumbox datumbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@pmeier pmeier merged commit 6af796a into pytorch:main Oct 28, 2022
@github-actions
Copy link

Hey @pmeier!

You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

@pmeier pmeier deleted the ignore-mypy branch October 28, 2022 09:52
facebook-github-bot pushed a commit that referenced this pull request Oct 31, 2022
Reviewed By: datumbox

Differential Revision: D40851021

fbshipit-source-id: 622da1386cf4a101ef2ecef24ca83d97f2f60ef9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants