Skip to content

Conversation

YosuaMichael
Copy link
Contributor

As part of the post-release process, we add the new version 0.14 to readme.

Note: this should only be merged after the release of torchvision 0.14.

@YosuaMichael YosuaMichael self-assigned this Oct 27, 2022
@datumbox datumbox marked this pull request as draft October 27, 2022 14:53
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Yosua

Note: this should only be merged after the release of torchvision 0.14.

In fact we might want to merge this one just before the release: this way, the README will be up-to-date on PyPI.

When we merge this PR after the release, this happens: the current README on PyPI is the readme from 0.12 (instead of 0.13!). This is because the wheels that were updated on PyPI were built before the PR was merged, and thus were relying on the "old" version of the readme.

This isn't a big deal though, just something nice to get right if we can.

@NicolasHug
Copy link
Member

BTW since we expect to release tonight, I think it's fine to merge it now - but it's up to you :)

@YosuaMichael YosuaMichael marked this pull request as ready for review October 27, 2022 17:19
@YosuaMichael YosuaMichael merged commit cb60e97 into pytorch:main Oct 27, 2022
@github-actions
Copy link

Hey @YosuaMichael!

You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

@YosuaMichael
Copy link
Contributor Author

Thanks @NicolasHug

When we merge this PR after the release, this happens: the current README on PyPI is the readme from 0.12 (instead of 0.13!). This is because the wheels that were updated on PyPI were built before the PR was merged, and thus were relying on the "old" version of the readme.

This is a good point, I will merge now (shortly before release), hopefully PyPI use 0.14 later.

facebook-github-bot pushed a commit that referenced this pull request Oct 31, 2022
Reviewed By: datumbox

Differential Revision: D40851022

fbshipit-source-id: 9f50a112f42afa5b561b4a9168d0cd24bb690f62
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants