Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[proto] Fixed fill type in AA #6621

Merged
merged 6 commits into from
Sep 22, 2022
Merged

[proto] Fixed fill type in AA #6621

merged 6 commits into from
Sep 22, 2022

Conversation

vfdev-5
Copy link
Collaborator

@vfdev-5 vfdev-5 commented Sep 21, 2022

Description:

  • Fixed fill type in AA

@datumbox
Copy link
Contributor

@vfdev-5 We missed the fill: Union[int, float, Sequence[int], Sequence[float]] = 0, in the constructors of the techniques. You only made the change on _AutoAugmentBase. Could you update the rest of the classes?

@vfdev-5
Copy link
Collaborator Author

vfdev-5 commented Sep 21, 2022

Thank! I should be blind

datumbox
datumbox approved these changes Sep 22, 2022
View reviewed changes
Copy link
Contributor

@datumbox datumbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@datumbox datumbox merged commit f49edd3 into pytorch:main Sep 22, 2022
@vfdev-5 vfdev-5 deleted the proto-fix-fill-type-in-aa branch September 22, 2022 08:45
facebook-github-bot pushed a commit that referenced this pull request Sep 23, 2022
@jdsgomes @datumbox @facebook-github-bot
[fbsync] [proto] Fixed fill type in AA (#6621)
df6b363 
Summary:
* [proto] Fixed fill type in AA

* Fixed missed typehints

* Set fill as None by default

* Another fix

Reviewed By: NicolasHug

Differential Revision: D39765312

fbshipit-source-id: 323184a91f0799cbac72f626f8338ea79cd8987c

Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datumbox datumbox datumbox approved these changes

Assignees
No one assigned
Labels
cla signed enhancement module: transforms prototype
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vfdev-5 @datumbox @facebook-github-bot