Add omniglot with new API

[vballoli]

PR for #5346

[facebook-github-bot]

Hi @vballoli!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

[facebook-github-bot]

💊 CI failures summary and remediations

As of commit 78c2abc (more details on the Dr. CI page):

---

• 3/3 failures introduced in this PR

---

🕵️ 2 new failures recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

type_check_python (1/2)

Step: " Install torchvision in editable mode
" (full log | diagnosis details | 🔁 rerun)

�[31mERROR: Command errored out with exit statu...refix= Check the logs for full command output.�[0m

      431 |         at::ScalarType::Byte, iter.dtype(), "upsample_generic_Nd", [&] {
          |         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      432 |           ti_cpu_upsample_generic_aa<scalar_t, index_t, out_ndims>(
          |           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      433 |               iter, interp_size);
          |               ~~~~~~~~~~~~~~~~~~~
      434 |         });
          |         ~~
    error: command 'gcc' failed with exit status 1
    ----------------------------------------�[0m
�[31mERROR: Command errored out with exit status 1: /usr/local/bin/python -c 'import io, os, sys, setuptools, tokenize; sys.argv[0] = '"'"'/home/circleci/project/setup.py'"'"'; __file__='"'"'/home/circleci/project/setup.py'"'"';f = getattr(tokenize, '"'"'open'"'"', open)(__file__) if os.path.exists(__file__) else io.StringIO('"'"'from setuptools import setup; setup()'"'"');code = f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' develop --no-deps --user --prefix= Check the logs for full command output.�[0m
�[33mWARNING: You are using pip version 21.2.4; however, version 22.0.4 is available.
You should consider upgrading via the '/usr/local/bin/python -m pip install --upgrade pip' command.�[0m


Exited with code exit status 1

unittest_prototype (2/2)

Step: " Install torchvision in editable mode
" (full log | diagnosis details | 🔁 rerun)

�[31mERROR: Command errored out with exit statu...refix= Check the logs for full command output.�[0m

      431 |         at::ScalarType::Byte, iter.dtype(), "upsample_generic_Nd", [&] {
          |         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      432 |           ti_cpu_upsample_generic_aa<scalar_t, index_t, out_ndims>(
          |           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      433 |               iter, interp_size);
          |               ~~~~~~~~~~~~~~~~~~~
      434 |         });
          |         ~~
    error: command 'gcc' failed with exit status 1
    ----------------------------------------�[0m
�[31mERROR: Command errored out with exit status 1: /usr/local/bin/python -c 'import io, os, sys, setuptools, tokenize; sys.argv[0] = '"'"'/home/circleci/project/setup.py'"'"'; __file__='"'"'/home/circleci/project/setup.py'"'"';f = getattr(tokenize, '"'"'open'"'"', open)(__file__) if os.path.exists(__file__) else io.StringIO('"'"'from setuptools import setup; setup()'"'"');code = f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' develop --no-deps --user --prefix= Check the logs for full command output.�[0m
�[33mWARNING: You are using pip version 21.2.4; however, version 22.0.4 is available.
You should consider upgrading via the '/usr/local/bin/python -m pip install --upgrade pip' command.�[0m


Exited with code exit status 1

---

1 failure not recognized by patterns:

Job	Step	Action
unittest_torchhub	Install torchvision in editable mode
	🔁 rerun

---

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

[vballoli]

@pmeier I'm slightly confused about the mocks error which completely slipped my mind when pushing this code. How is the DatasetConfig passed here (I believe this is something I missed causing the error AttributeError: 'DatasetConfig' object has no attribute 'split' )

[pmeier]

@vballoli You forgot to add valid_options to the DatasetInfo. Without that, config is just an empty namespace.

[pmeier]

Suggested change

	return DatasetInfo(
	"omniglot", type=DatasetType.RAW, categories=None, homepage="https://github.com/brendenlake/omniglot"
	)
	return DatasetInfo(
	"omniglot", type=DatasetType.RAW, categories=None, homepage="https://github.com/brendenlake/omniglot",
	valid_options=dict(split=("background", "evaluation")),
	)

[vballoli]

Got busy again, sorry for the delay in fixing this error. Will have an update in a day or 2.