Remove in-place mutation in DefaultBoxGenerator #5279
Conversation
|
Hi @masahi! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
💊 CI failures summary and remediationsAs of commit d5a2603 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
@masahi I will merge once the CI passes. |
Summary: * Remove in-place mutation in DefaultBoxGenerator * device fix * Update torchvision/models/detection/anchor_utils.py Reviewed By: kazhang Differential Revision: D33927514 fbshipit-source-id: 83cad27f7ef6a6135830750691299753fecdbca5 Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>
3 participants
This replaces in-place mutation with more backend compiler-friendly one. In-place ops generally cause problems for TVM, so we want an input model to be as pure as possible.
A related issue apache/tvm#10050