Skip to content

Add seek in GPU decoder #5215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 24, 2022
Merged

Add seek in GPU decoder #5215

merged 6 commits into from
Jan 24, 2022

Conversation

prabhat00155
Copy link
Contributor

Resolves #5139.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jan 19, 2022 •
edited
Loading

💊 CI failures summary and remediations

As of commit a8dd825 (more details on the Dr. CI page):

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@prabhat00155 prabhat00155 marked this pull request as draft January 19, 2022 11:49
@prabhat00155 prabhat00155 marked this pull request as ready for review January 20, 2022 20:26
@prabhat00155 prabhat00155 requested a review from bjuncek January 20, 2022 20:26
jdsgomes
jdsgomes reviewed Jan 24, 2022
View reviewed changes
Copy link
Contributor

@jdsgomes jdsgomes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor clarification, otherwise looks great to me.

@prabhat00155 prabhat00155 requested a review from jdsgomes January 24, 2022 12:12
jdsgomes
jdsgomes approved these changes Jan 24, 2022
View reviewed changes
Copy link
Contributor

@jdsgomes jdsgomes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@prabhat00155 prabhat00155 merged commit b21e0bf into pytorch:main Jan 24, 2022
@prabhat00155 prabhat00155 deleted the prabhat00155/add_seek branch January 24, 2022 14:57
@bjuncek
Copy link
Contributor

bjuncek commented Jan 24, 2022

Looks good to me; on the test/pyav side, have we manually confirmed that "seek" does the same thing (i.e. that it doesn't go to keyframes)?

facebook-github-bot pushed a commit that referenced this pull request Feb 3, 2022
@yiwen-song @facebook-github-bot
[fbsync] Add seek in GPU decoder (#5215)
af747ad 
Summary:
* Add seek in GPU decoder

* Merge the two tests

* Refine unit test

Reviewed By: kazhang

Differential Revision: D33927515

fbshipit-source-id: b195b5dbab44533e6e73c648e61eba4fd6f4f5ed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bjuncek bjuncek Awaiting requested review from bjuncek

1 more reviewer

@jdsgomes jdsgomes jdsgomes approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ciflow/default cla signed enhancement module: io module: video

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add seek functionality to GPU decoder

4 participants

@prabhat00155 @facebook-github-bot @bjuncek @jdsgomes