Skip to content

fix category file generation #5188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 14, 2022
Merged

Conversation

pmeier
Copy link
Collaborator

@pmeier pmeier commented Jan 11, 2022

#5133 changed some semantics of how the category files are generated, but this was not included in the recent dataset additions.

cc @pmeier @bjuncek

@facebook-github-bot
Copy link

facebook-github-bot commented Jan 11, 2022

💊 CI failures summary and remediations

As of commit 9f31f3e (more details on the Dr. CI page):


💚 💚 Looks good so far! There are no failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pmeier !

@pmeier pmeier merged commit 1feb637 into pytorch:main Jan 14, 2022
@pmeier pmeier deleted the fix-category-file-gen branch January 14, 2022 12:42
facebook-github-bot pushed a commit that referenced this pull request Jan 17, 2022
Reviewed By: NicolasHug

Differential Revision: D33618168

fbshipit-source-id: b98196d7b518142e670603a9eb320f6ef37aab47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants