Country dataset

[puhuk]

cc @pmeier

[facebook-github-bot]

💊 CI failures summary and remediations

As of commit f0883a5 (more details on the Dr. CI page):

---

💚 💚 Looks good so far! There are no failures yet. 💚 💚

---

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

[pmeier]

Hey @puhuk, thanks a lot for the PR. I've added a few comments inline. There are three more issues:

1. You used find_classes and make_dataset to create the dataset. This is far better than doing it yourself, but it would be even better to simply subclass ImageFolderDataset so you don't have to worry about that at all. Basically, you only need to handle the input parsing and download and simply pass os.path.join(root, "country", self._split) to super().__init__() (along with the transforms of course). If you do that, you don't need to define __len__ and __getitem__ at all.
2. Could you add the dataset to our documentation? For that, simply add the class name to the list in docs/source/datasets.rst.
3. Could you add tests for the dataset? You can create a Country211TestCase in this file. You basically only need to provide a minimal configuration as well as provide fake data. You can read this docstring or look at the other test cases for examples. Due to the very easy structure, all the fake data can be created by datasets_utils.create_image_folder.

[puhuk]

@pmeier Thank you for your kind review. Let me check and correct it soon :)

[puhuk]

@pmeier I resend PR with your suggestion and test code.
But there are errors, could you advise me about how to resolve this.

[pmeier]

@puhuk I suggested some changes inline. After that, my comment for inheriting from ImageFolderDataset (#5138 (review)) is still open. Let me know if you need help with that.

Don't worry about the merge conflicts yet, we can fix them before merge. Plus, there are some unrelated failing test that you also don't need to worry about.

[puhuk]

@pmeier I resend the PR with your review.
But I don't exactly understand how to implement by inheriting ImageFolderDataset.
May I ask for your help with this.

[pmeier]

@puhuk I pushed the changes to inherit from ImageFolder. There are two things left to fix in the docstring. Afterwards this is good to go.

[NicolasHug]

Thanks a lot @puhuk for the PR and @pmeier for the review!

In 9eb4f11 I pushed some minor changes to address @pmeier 's last comments, and to make the tests slightly more robust. LGTM, I'll merge when green. Thanks again!

[puhuk]

@pmeier Really thanks to your review and re-creation of my humble code.
Hope to contribute with better code in next time.