Skip to content

Conversation

ethanwhite
Copy link
Contributor

@ethanwhite ethanwhite commented Nov 11, 2021

Fixes #4905

Default values for models using trainable_backbone_layers=None can be confusing since it is not clear in the top level function documentation what value is used when not setting the optional argument (see #4905).

This PR provides that information for each model using trainable_backbone_layers=None in the associated docstring.

@facebook-github-bot
Copy link
Contributor

Hi @ethanwhite!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Nov 11, 2021

💊 CI failures summary and remediations

As of commit f880d0f (more details on the Dr. CI page):


💚 💚 Looks good so far! There are no failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Copy link
Contributor

@datumbox datumbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT, thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@datumbox datumbox merged commit a2f6565 into pytorch:main Nov 11, 2021
cyyever pushed a commit to cyyever/vision that referenced this pull request Nov 16, 2021
Closes pytorch#4905

Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>
facebook-github-bot pushed a commit that referenced this pull request Nov 17, 2021
Summary:
Closes #4905

Reviewed By: datumbox

Differential Revision: D32470474

fbshipit-source-id: 5b89a39e6571fac238473f606784dd3a49f9c22c

Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clarify documentation/defaults for trainable_backbone_layers

3 participants