-
Notifications
You must be signed in to change notification settings - Fork 7.2k
Default value docs for models using trainable_backbone_layers #4913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @ethanwhite! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
💊 CI failures summary and remediationsAs of commit f880d0f (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
e809198
to
11e363b
Compare
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT, thanks!
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Closes pytorch#4905 Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>
Summary: Closes #4905 Reviewed By: datumbox Differential Revision: D32470474 fbshipit-source-id: 5b89a39e6571fac238473f606784dd3a49f9c22c Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>
Fixes #4905
Default values for models using
trainable_backbone_layers=None
can be confusing since it is not clear in the top level function documentation what value is used when not setting the optional argument (see #4905).This PR provides that information for each model using
trainable_backbone_layers=None
in the associated docstring.