Skip to content

Set seed on test_nms_ref to reduce flakiness #4911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 11, 2021
Merged

Set seed on test_nms_ref to reduce flakiness #4911

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2f5cc53
Set seed on test_nms_ref to reduce flakiness
datumbox Nov 11, 2021
31bd6dd
Merge branch 'main' into tests/fix_flaky_nms_ref
datumbox Nov 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion test/test_ops.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -479,7 +479,9 @@ def _create_tensors_with_iou(self, N, iou_thresh):
return boxes, scores

@pytest.mark.parametrize("iou", (0.2, 0.5, 0.8))
def test_nms_ref(self, iou):
@pytest.mark.parametrize("seed", range(10))
def test_nms_ref(self, iou, seed):
torch.random.manual_seed(seed)
err_msg = "NMS incompatible between CPU and reference implementation for IoU={}"
boxes, scores = self._create_tensors_with_iou(1000, iou)
keep_ref = self._reference_nms(boxes, scores, iou)
Expand Down