Reverted folder.py back to using complete path to file for make_dataset #4885
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…et and is_valid_file rather than just the filename
💊 CI failures summary and remediationsAs of commit 6f82595 (more details on the Dr. CI page):
1 failure not recognized by patterns:
This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
pmeier
approved these changes
Nov 9, 2021
|
Hey @datumbox! You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py |
datumbox
added
module: datasets
revert(ed)
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 15, 2021
…ake_dataset and is_valid_file rather than just the filename (#4885) Summary: Co-authored-by: Alexander Unnervik <alex.unnervik@idiap.ch> Reviewed By: datumbox Differential Revision: D32298975 fbshipit-source-id: d6b2fc4bf14e05acf45ae77eb675032b1ea671ae
cyyever
pushed a commit
to cyyever/vision
that referenced
this pull request
Nov 16, 2021
…et and is_valid_file rather than just the filename (pytorch#4885) Co-authored-by: Alexander Unnervik <alex.unnervik@idiap.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4871 by reverting back the change introduced in #3939.
cc @pmeier