Skip to content

Ignore platforms other than Linux for ffmpeg #4410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 14, 2021
Merged

Ignore platforms other than Linux for ffmpeg #4410

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
776d809
Fix ffmpeg version
prabhat00155 Sep 13, 2021
f800db1
Ignore platforms other than Linux for ffmpeg
prabhat00155 Sep 14, 2021
31b72a3
Removed unnecessary changes
prabhat00155 Sep 14, 2021
01169a8
Merge branch 'master' into prabhat00155/fix_ffmpeg
prabhat00155 Sep 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,6 +351,8 @@ def get_extensions():

ffmpeg_exe = distutils.spawn.find_executable('ffmpeg')
has_ffmpeg = ffmpeg_exe is not None
if sys.platform != 'linux':
has_ffmpeg = False
if has_ffmpeg:
try:
# this splits on both dots and spaces as the output format differs across versions / platforms
Expand All @@ -360,7 +362,7 @@ def get_extensions():
if StrictVersion(ffmpeg_version) >= StrictVersion('4.3'):
print(f'ffmpeg {ffmpeg_version} not supported yet, please use ffmpeg 4.2.')
has_ffmpeg = False
except (IndexError, ValueError):
except (subprocess.CalledProcessError, IndexError, ValueError):
print('Error fetching ffmpeg version, ignoring ffmpeg.')
has_ffmpeg = False

Expand Down