Skip to content

Disabling the video tests that seg fault #4405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

Disabling the video tests that seg fault #4405

wants to merge 4 commits into from

Conversation

datumbox
Copy link
Contributor

@datumbox datumbox commented Sep 14, 2021 •
edited
Loading

The specific tests cause the CI to seg fault on MacOS. Skipping it temporarily until #4402 is resolved, to enable the execution of the remaining tests.

cc @pmeier

vfdev-5
vfdev-5 approved these changes Sep 14, 2021
View reviewed changes
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @datumbox

@datumbox datumbox changed the title Disabling test_probe_video_from_file test Disabling the tests at TestVideo Sep 14, 2021
@datumbox datumbox changed the title Disabling the tests at TestVideo Disabling the video tests that seg fault Sep 14, 2021
@datumbox datumbox mentioned this pull request Sep 14, 2021
Closed
@prabhat00155
Copy link
Contributor

Thanks @datumbox for fixing this. I'm working on moving torchvision to use the latest ffmpeg. There are some issues on Mac though which I am working on fixing. We can go two ways here:

  • I make the change and skip building ffmpeg on Mac.
  • We skip the tests until the Mac build(with ffmpeg) is fixed.

@datumbox
Copy link
Contributor Author

@prabhat00155 Thanks mate. Feel free to close this in favour of skipping building on MacOS if you want. Totally up to you.

@julienripoche julienripoche mentioned this pull request Sep 14, 2021
Merged
@prabhat00155
Copy link
Contributor

Closing this PR as the issue was fixed by #4410.

@datumbox datumbox deleted the disable_video_test branch September 14, 2021 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vfdev-5 vfdev-5 vfdev-5 approved these changes

@prabhat00155 prabhat00155 Awaiting requested review from prabhat00155

Assignees
No one assigned
Labels
module: tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@datumbox @prabhat00155 @vfdev-5 @facebook-github-bot