Don't check transparency channel for pil >= 8.3 #4167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
pushed a commit
that referenced
this pull request
Jul 27, 2021
…de_png (#4167) Reviewed By: fmassa Differential Revision: D29932697 fbshipit-source-id: 354d2aa97cd865b87864ccc8cb7e1d7722bbaf64
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
png decoding tests are currently failing. Looking into it, the issue appeared in pillow 8.3 and I reported it in python-pillow/Pillow#5593 (comment). The problem comes from PIL not properly setting the transparency channel of some images.
This is a temporary workaround (we ignore the check in those conditions) which should be removed once the fix is published in pillow.
As a bonus this uses
torch.testing.assert_closeinstead oftorch.allclose