Added warning message for unsupported ffmpeg version #4041
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datumbox
approved these changes
Jun 11, 2021
datumbox
reviewed
Jun 11, 2021
|
Hey @datumbox, @prabhat00155! You approved or merged this PR, but no labels were added. |
@NicolasHug, @datumbox , @fmassa I see labels in this PR, what is this talking about? |
|
You need to put one of the "module" labels or bug/improvement/new feature, etc. I think we should document the process a bit better because I understand now it's a bit confusing. :) |
Okay, thank you! |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 14, 2021
Summary: * Added warning message for unsupported ffmpeg version * Replaced os.popen with subprocess.run * Removed capture_true argument Reviewed By: fmassa Differential Revision: D29097707 fbshipit-source-id: 775eae7ba0004462be80eaed232f75a6336ad107
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4022.