Fix pointer to contiguous data in quantized roi_align #3904
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicolasHug
added
bug
module: ops
module: models.quantization
datumbox
approved these changes
May 24, 2021
|
Thanks for the fast review! |
facebook-github-bot
pushed a commit
that referenced
this pull request
May 25, 2021
Reviewed By: vincentqb, cpuhrsch Differential Revision: D28679963 fbshipit-source-id: dffae9aa3764472685d5b45be6e62949d8eb318d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the result of
t_input.contiguous().data_ptr<T>();is unsafe if t_input isn't contiguous in the first place, as thet_input.contiguous()tensor is undefined right after that block. Instead, we should keep the temporary tensors around.Related internal post: https://fb.workplace.com/groups/1405155842844877/permalink/4735263356500759/
Similar past PR: #2131
CC @fmassa