Use torch.testing.assert_close in test_anchor_utils.py #3880
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicolasHug
commented
May 21, 2021
Comment on lines
+89
to
+90
| torch.testing.assert_close(dboxes[0], dboxes_output, rtol=1e-5, atol=1e-8) | ||
| torch.testing.assert_close(dboxes[1], dboxes_output, rtol=1e-5, atol=1e-8) |
There was a problem hiding this comment.
Here it's a bit of a shame IMHO that we're forced to specify atol as well. The default for atol is 1e-5 and
torch.testing.assert_close(dboxes[0], dboxes_output, rtol=1e-5, atol=1e-5)
torch.testing.assert_close(dboxes[1], dboxes_output, rtol=1e-5, atol=1e-5)passes just fine, so ideally we could just write
torch.testing.assert_close(dboxes[0], dboxes_output, rtol=1e-5)
torch.testing.assert_close(dboxes[1], dboxes_output, rtol=1e-5)
facebook-github-bot
pushed a commit
that referenced
this pull request
May 25, 2021
Summary: Co-authored-by: Philip Meier <github.pmeier@posteo.de> Reviewed By: vincentqb, cpuhrsch Differential Revision: D28679964 fbshipit-source-id: c53eb63031a4b965e870f3334d749e4d9d41ddad
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #3865