-
Notifications
You must be signed in to change notification settings - Fork 7.2k
[iOS] added VisionTestApp for testing vision ops #3629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
Hi @husthyc Is the PR ready for review? Could you extend the description in the PR with instructions on how to get the app running? |
[ghstack-poisoned]
|
### How to build & run the test app via Xcode - `cd` to `ios/VisionTestApp` - run `./setup.sh` - open `VisionTestApp.xcodeproj` using Xcode - build & run (supports both simulators and real devices) - check if the benchmark result can be displayed on the view - if you want to check in some code, make sure you run `./clean.sh` before commit so that the model file and static libs will not be committed [ghstack-poisoned]
@husthyc I gave this a go and getting the app to run was very simple, thanks! I noticed that currently a dummy image is used, leading to zero detections. Would it be possible to show the forward pass on a real image in order to have a more robust coverage of the pipeline? Thanks! |
Sure, will update accordingly. |
Hi @husthyc , just checking in: I see you have requested a review from me but I don't think the PR has been updated since my last comment: #3629 (comment) Did you get a chance to implement the forward pass on a real image? Thanks! |
@NicolasHug note that the PR that you merged (which was sent with ghstack) was not merged in master but in a ghstack branch. You'll need to cherry-pick this commit into a commit that needs to be sent to master |
@husthyc I am unable to build the VisionTestApp. The libraries fails to build with the below error. Is there any additional build settings to be made to run the source.
Xcode version: 12.5 |
@devbooleans any updates? I am also facing the same issue. Thanks a lot! |
facing the same issue |
Stack from ghstack:
How to build & run the test app via Xcode
cd
toios/VisionTestApp
./setup.sh
(this step requires yourwget
is pre-installed and make sure your Python torch and Python vision are up to date so that the model is able to be generated)VisionTestApp.xcodeproj
using Xcode./clean.sh
before commit so that the model file and static libs will not be committed