-
Notifications
You must be signed in to change notification settings - Fork 7.2k
Remove unneeded packaging files #3618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3618 +/- ##
=======================================
Coverage 79.68% 79.68%
=======================================
Files 105 105
Lines 9822 9822
Branches 1582 1582
=======================================
Hits 7827 7827
Misses 1517 1517
Partials 478 478 Continue to review full report at Codecov.
|
@peterjc123 could you have a look to double-check that this was what you had in mind? |
Sure, please do that. |
Yeah. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the changes look good. @fmassa Please merge if the builds are green.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Summary: * remove some files * Also remove entire packaging/conda folder Reviewed By: NicolasHug Differential Revision: D27706936 fbshipit-source-id: 21d775d0cb5d03926cf436a3e74e0d5f67928f33 Co-authored-by: Francisco Massa <fvsmassa@gmail.com>
Closes #3617
This PR removes some unneeded packaging files
Original post says we can remove all scripts in
packaging/conda/
but they all seem to be scripts. Should we remove the directory altogether?