Skip to content

Conversation

NicolasHug
Copy link
Member

Closes #3617

This PR removes some unneeded packaging files

Original post says we can remove all scripts in packaging/conda/ but they all seem to be scripts. Should we remove the directory altogether?

@codecov
Copy link

codecov bot commented Mar 30, 2021

Codecov Report

Merging #3618 (6d9560f) into master (226126b) will not change coverage.
The diff coverage is n/a.

❗ Current head 6d9560f differs from pull request most recent head f97b940. Consider uploading reports for the commit f97b940 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3618   +/-   ##
=======================================
  Coverage   79.68%   79.68%           
=======================================
  Files         105      105           
  Lines        9822     9822           
  Branches     1582     1582           
=======================================
  Hits         7827     7827           
  Misses       1517     1517           
  Partials      478      478           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 226126b...f97b940. Read the comment docs.

@fmassa fmassa requested a review from peterjc123 March 30, 2021 16:18
@fmassa
Copy link
Member

fmassa commented Mar 30, 2021

@peterjc123 could you have a look to double-check that this was what you had in mind?

@peterjc123
Copy link
Contributor

Original post says we can remove all scripts in packaging/conda/ but they all seem to be scripts. Should we remove the directory altogether?

Sure, please do that.

@peterjc123
Copy link
Contributor

@peterjc123 could you have a look to double-check that this was what you had in mind?

Yeah.

Copy link
Contributor

@peterjc123 peterjc123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the changes look good. @fmassa Please merge if the builds are green.

Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fmassa fmassa merged commit 968cefc into pytorch:master Mar 30, 2021
facebook-github-bot pushed a commit that referenced this pull request Apr 13, 2021
Summary:
* remove some files

* Also remove entire packaging/conda folder

Reviewed By: NicolasHug

Differential Revision: D27706936

fbshipit-source-id: 21d775d0cb5d03926cf436a3e74e0d5f67928f33

Co-authored-by: Francisco Massa <fvsmassa@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

packaging/windows/cuda101.bat not used anymore?

4 participants