Skip to content

removed duplicate as #3591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 20, 2021
Merged

removed duplicate as #3591

merged 2 commits into from
Mar 20, 2021

Conversation

urmi22
Copy link
Contributor

@urmi22 urmi22 commented Mar 19, 2021

Fixes #3590

@facebook-github-bot
Copy link
Contributor

Hi @urmi22!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@codecov
Copy link

codecov bot commented Mar 19, 2021 •
edited
Loading

Codecov Report

Merging #3591 (0d4a583) into master (c00c4d3) will not change coverage.
The diff coverage is n/a.

❗ Current head 0d4a583 differs from pull request most recent head 90775aa. Consider uploading reports for the commit 90775aa to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3591   +/-   ##
=======================================
  Coverage   79.07%   79.07%           
=======================================
  Files         105      105           
  Lines        9786     9786           
  Branches     1572     1572           
=======================================
  Hits         7738     7738           
  Misses       1567     1567           
  Partials      481      481
Impacted Files Coverage Δ
torchvision/models/detection/transform.py 78.45% <ø> (ø)
torchvision/transforms/transforms.py 84.30% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae1acbf...90775aa. Read the comment docs.

pmeier
pmeier approved these changes Mar 20, 2021
View reviewed changes
Copy link
Collaborator

@pmeier pmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot @urmi22!

@pmeier pmeier requested a review from fmassa March 20, 2021 09:50
datumbox
datumbox approved these changes Mar 20, 2021
View reviewed changes
Copy link
Contributor

@datumbox datumbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@datumbox datumbox merged commit 5f0532d into pytorch:master Mar 20, 2021
facebook-github-bot pushed a commit that referenced this pull request Apr 1, 2021
@parmeet @datumbox @facebook-github-bot
[fbsync] removed duplicate as (#3591)
a935f99 
Summary:

Reviewed By: fmassa

Differential Revision: D27433930

fbshipit-source-id: c22b94f487967de4c59f2f264bbd421629012ca0

Co-authored-by: urmi22 <debjanimazumder22@example.com>
Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pmeier pmeier pmeier approved these changes

@fmassa fmassa Awaiting requested review from fmassa

+1 more reviewer

@datumbox datumbox datumbox approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla signed code quality

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

This may be has extra "as"

5 participants

@urmi22 @facebook-github-bot @datumbox @pmeier @NicolasHug