Skip to content

fix VOC datasets for 2007 #3572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 17, 2021
Merged

fix VOC datasets for 2007 #3572

merged 2 commits into from
Mar 17, 2021

Conversation

pmeier
Copy link
Collaborator

@pmeier pmeier commented Mar 15, 2021

Fixes #3571. #3415 regressed the download of any image_set other than test for year="2007".

@codecov
Copy link

codecov bot commented Mar 15, 2021 •
edited
Loading

Codecov Report

Merging #3572 (ec16181) into master (00c460a) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head ec16181 differs from pull request most recent head 948a268. Consider uploading reports for the commit 948a268 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3572      +/-   ##
==========================================
- Coverage   79.07%   79.05%   -0.02%     
==========================================
  Files         105      105              
  Lines        9787     9785       -2     
  Branches     1572     1571       -1     
==========================================
- Hits         7739     7736       -3     
- Misses       1567     1568       +1     
  Partials      481      481
Impacted Files Coverage Δ
torchvision/datasets/voc.py 94.44% <100.00%> (-0.07%) ⬇️
torchvision/datasets/mnist.py 55.60% <0.00%> (-0.62%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00c460a...948a268. Read the comment docs.

@pmeier pmeier requested a review from fmassa March 15, 2021 17:17
fmassa
fmassa approved these changes Mar 17, 2021
View reviewed changes
Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fmassa fmassa merged commit c00c4d3 into pytorch:master Mar 17, 2021
@fmassa
Copy link
Member

fmassa commented Mar 17, 2021

We need to cherry-pick this fix to the release branch as well, as it was present in the 0.9 release

@pmeier pmeier deleted the fix-voc branch March 17, 2021 15:10
pmeier added a commit to pmeier/vision that referenced this pull request Mar 17, 2021
@pmeier @fmassa
fix VOC datasets for 2007 (pytorch#3572)
a955388 
Co-authored-by: Francisco Massa <fvsmassa@gmail.com>
@fmassa fmassa mentioned this pull request Mar 17, 2021
Closed
fmassa added a commit that referenced this pull request Mar 17, 2021
@pmeier @fmassa
fix VOC datasets for 2007 (#3572) (#3580)
91b3ef2 
Co-authored-by: Francisco Massa <fvsmassa@gmail.com>

Co-authored-by: Francisco Massa <fvsmassa@gmail.com>
facebook-github-bot pushed a commit that referenced this pull request Mar 19, 2021
@vincentqb @facebook-github-bot
[fbsync] fix VOC datasets for 2007 (#3572)
2849ae3 
Summary: Co-authored-by: Francisco Massa <fvsmassa@gmail.com>

Reviewed By: fmassa

Differential Revision: D27128000

fbshipit-source-id: b918dd8eff9beb621551a077b64b0d7f4deb3bbf
@datumbox datumbox added bug and removed fix labels Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fmassa fmassa fmassa approved these changes

Assignees

No one assigned

Labels

bug cla signed module: datasets

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

VOCDetection year=‘2007’ Problem

4 participants

@pmeier @fmassa @datumbox @facebook-github-bot