Skip to content

Use pytorch smooth_l1_loss and remove private custom implem #3539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 10, 2021
Merged

Use pytorch smooth_l1_loss and remove private custom implem #3539

merged 2 commits into from
Mar 10, 2021

Conversation

NicolasHug
Copy link
Member

This PR removes the custom implementation of smooth_l1_loss and uses the one from pytorch, now that it supports the beta parameter

fmassa
fmassa approved these changes Mar 10, 2021
View reviewed changes
Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fmassa fmassa merged commit 797fd26 into pytorch:master Mar 10, 2021
facebook-github-bot pushed a commit that referenced this pull request Mar 10, 2021
@fmassa @facebook-github-bot
[fbsync] Use pytorch smooth_l1_loss and remove private custom implem (#…
a198fc3 
…3539)

Reviewed By: NicolasHug, cpuhrsch

Differential Revision: D26945725

fbshipit-source-id: c7f300b6eb54e496947cda4502bcdcd4fc1d6bc7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fmassa fmassa fmassa approved these changes

Assignees

No one assigned

Labels

cla signed code quality module: models

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@NicolasHug @fmassa @facebook-github-bot