Add tests for the PhotoTour dataset #3486
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmassa
reviewed
Mar 2, 2021
Closed
fmassa
approved these changes
Mar 2, 2021
| if self.train: | ||
| return self.lens[self.name] | ||
| return len(self.matches) | ||
| return len(self.data if self.train else self.matches) |
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 4, 2021
Summary: * add tests for PhotoTour dataset * fix grayscale image generation * fix test_feature_types for a examples of a single feature * make image size variable instead of hard coding it * make dataset length variable instead of hard coding it * replace numpy with torch * fix typo Reviewed By: fmassa Differential Revision: D26756270 fbshipit-source-id: 62a8a7508be74580ca462089131f1aff4dd020cb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.