Skip to content

Conversation

pmeier
Copy link
Collaborator

@pmeier pmeier commented Feb 23, 2021

Right now the docstring of datasets.PhotoTour references the original version of the dataset while our implementation relies on the updated version. This PR fixes the docstring and adds a note about the original version.

Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vfdev-5 vfdev-5 merged commit a24191e into pytorch:master Feb 25, 2021
@pmeier pmeier deleted the fix-phototour-doc branch February 25, 2021 12:21
facebook-github-bot pushed a commit that referenced this pull request Mar 4, 2021
Summary: Co-authored-by: vfdev <vfdev.5@gmail.com>

Reviewed By: fmassa

Differential Revision: D26756266

fbshipit-source-id: 8f39e99a183456a8aa24fdcdf9cd592fdb3d8775
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants