[BC-breaking] remove normalize from save_image #3324
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datumbox
approved these changes
Jan 29, 2021
Codecov Report
@@ Coverage Diff @@
## master #3324 +/- ##
=======================================
Coverage 73.97% 73.97%
=======================================
Files 104 104
Lines 9606 9606
Branches 1537 1537
=======================================
Hits 7106 7106
Misses 2023 2023
Partials 477 477
Continue to review full report at Codecov.
|
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 4, 2021
Reviewed By: datumbox Differential Revision: D26226617 fbshipit-source-id: 874d01718da096645ad61307a071f036470c1f07
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
normalizeparameter has currently no effect on thesave_image()method due to a bug. The parameter was probably introduced accidentally in the method signature and by defining it, it is no longer captured in thekwargsand passed to themake_grid()method as intended.This PR fixes the bug by removing the declaration from
save_image(), letting it be captured bykwargsand passed tomake_grid(). Though it's unlikely to break any code, we mark it as BC-breaking because it removes a parameter from the signature. For more information check #3299 (comment)CC @datumbox, @fmassa