Skip to content

Increase tol in DeformConv2d test for more robustness #3320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 28, 2021

Conversation

NicolasHug
Copy link
Member

Closes #3060

As discussed in the original issue, slightly increasing the tolerance of the equality check for float16 will help make the test less flaky.

Copy link
Contributor

@datumbox datumbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks.

@codecov
Copy link

codecov bot commented Jan 28, 2021

Codecov Report

Merging #3320 (bd0a003) into master (9aa0722) will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3320      +/-   ##
==========================================
+ Coverage   73.84%   73.93%   +0.08%     
==========================================
  Files         104      104              
  Lines        9606     9594      -12     
  Branches     1537     1531       -6     
==========================================
- Hits         7094     7093       -1     
+ Misses       2033     2024       -9     
+ Partials      479      477       -2     
Impacted Files Coverage Δ
torchvision/transforms/transforms.py 83.69% <0.00%> (-0.42%) ⬇️
torchvision/transforms/functional_tensor.py 79.23% <0.00%> (+0.19%) ⬆️
torchvision/models/detection/anchor_utils.py 94.66% <0.00%> (+1.33%) ⬆️
torchvision/ops/deform_conv.py 72.30% <0.00%> (+3.07%) ⬆️
torchvision/extension.py 67.21% <0.00%> (+13.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9aa0722...1091dd9. Read the comment docs.

@datumbox datumbox merged commit a3c0e67 into pytorch:master Jan 28, 2021
facebook-github-bot pushed a commit that referenced this pull request Feb 4, 2021
Summary: Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>

Reviewed By: datumbox

Differential Revision: D26226609

fbshipit-source-id: 34ec6889588db957f61f6a6327970b60ffb5b42b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix DeformConv2d's autocast test flakiness
3 participants