Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily disable broken RCNN Onnx tests #3310

Merged
merged 3 commits into from
Jan 27, 2021

Conversation

datumbox
Copy link
Contributor

@datumbox datumbox commented Jan 27, 2021

Temporarily patches #3251

Disabling failing onnx tests related to rcnn until the pytorch/pytorch#50910 fix is merged upstream.

Copy link
Contributor

@mthrok mthrok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

token approval

@codecov
Copy link

codecov bot commented Jan 27, 2021

Codecov Report

Merging #3310 (858b58c) into master (d8eb22d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3310   +/-   ##
=======================================
  Coverage   73.93%   73.93%           
=======================================
  Files         104      104           
  Lines        9594     9594           
  Branches     1531     1531           
=======================================
  Hits         7093     7093           
  Misses       2024     2024           
  Partials      477      477           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8eb22d...ce4d5c4. Read the comment docs.

@datumbox datumbox merged commit 691ec6d into pytorch:master Jan 27, 2021
@datumbox datumbox deleted the tests/onnx_rcnn_disable branch January 27, 2021 16:37
@fmassa
Copy link
Member

fmassa commented Jan 27, 2021

cc @neginraoof, @spandantiwari for visibility

@spandantiwari
Copy link

Thanks @fmassa . We will take a look.

@zhiqwang
Copy link
Contributor

zhiqwang commented Jan 28, 2021

It seems that onnx can be used in the latest released pytorch-nightly version.

@datumbox
Copy link
Contributor Author

@zhiqwang Thanks for the heads up, I'll check now.

datumbox added a commit that referenced this pull request Jan 28, 2021
facebook-github-bot pushed a commit that referenced this pull request Feb 1, 2021
Reviewed By: datumbox

Differential Revision: D26156367

fbshipit-source-id: e5b871da8d42f648d6730a3eb736687eface4037
@datumbox datumbox added the bug label Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants