Rename image cpu files with _impl suffix #3308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datumbox
approved these changes
Jan 27, 2021
There was a problem hiding this comment.
LGTM! I would leave the _kernel renaming for now. I have it on the TODOs on a separate ticket (#3155).
Before merging it might be worth checking that this does not break anything on FBcode. I'll approve but let's talk offline on how to do the check.
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 1, 2021
Summary: Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com> Reviewed By: datumbox Differential Revision: D26156383 fbshipit-source-id: e444e164cc9f25f3dd9d9761e461f79c9bab878f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3162
This PR renames
s/_cpu/_implfor the files intorchvision/csrc/io/image/cpuShould I go ahead and also rename
s/_kernel/_implfor the files intorchvision/csrc/ops/cpu?