[release/0.7] .circleci: Remove CUDA 9.2 for windows #2504
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is an outstanding issue with JIT for pytorch binaries compiled with Visual Studio 2014. Since CUDA 9.2 is only compilable with Visual Studio 2014 we have decided to drop it altogether. Signed-off-by: Eli Uriegas <eliuriegas@fb.com>
Codecov Report
@@ Coverage Diff @@
## release/0.7 #2504 +/- ##
============================================
Coverage 68.58% 68.58%
============================================
Files 93 93
Lines 7608 7608
Branches 1159 1159
============================================
Hits 5218 5218
Misses 2064 2064
Partials 326 326 Continue to review full report at Codecov.
|
|
@seemethere I can accept this as a final attempt if we could not get the issue out before release. |
peterjc123
approved these changes
Jul 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an outstanding issue with JIT for pytorch binaries compiled
with Visual Studio 2014.
Since CUDA 9.2 is only compilable with Visual Studio 2014 we have
decided to drop it altogether.
Signed-off-by: Eli Uriegas eliuriegas@fb.com