Make Googlnet & InceptionNet scriptable #1349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
blocked by pytorch/pytorch#26437 |
fmassa
force-pushed
the
googlenet_scriptable
branch
from
4d10bab
to
46dd08c
Compare
eellison
changed the title
fmassa
reviewed
Sep 24, 2019
test/test_models.py
Outdated
| @@ -55,7 +53,7 @@ def check_script(self, model, name): | |||
| tb = traceback.format_exc() | |||
| scriptable = False | |||
| msg = str(e) + str(tb) | |||
| self.assertEqual(torchub_models[name], scriptable, msg) | |||
| self.assertEqual(scriptable, scriptable, msg) | |||
There was a problem hiding this comment.
I'm not sure this change is what you want to do?
There was a problem hiding this comment.
Since they are all scriptable now, we don't need to access torchub_models and just assert that scriptable is True
There was a problem hiding this comment.
Can you then make
self.assertEqual(scriptable, True, msg)There was a problem hiding this comment.
oh oops - good catch
|
Test failures look legit |
|
@pytorchbot rebase this please |
added 6 commits
September 25, 2019 12:48
…enet_scriptable
…enet_scriptable
Codecov Report
@@ Coverage Diff @@
## master #1349 +/- ##
==========================================
+ Coverage 63.9% 63.94% +0.03%
==========================================
Files 78 78
Lines 6147 6176 +29
Branches 940 944 +4
==========================================
+ Hits 3928 3949 +21
- Misses 1941 1947 +6
- Partials 278 280 +2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the conclusion from #1273: we are always returning a tuple when scripting.
This was blocked by pytorch/pytorch#26683.