Make Googlnet & InceptionNet scriptable - #1349
Conversation
|
blocked by pytorch/pytorch#26437 |
4d10bab to
46dd08c
Compare
eellison
changed the title
fmassa
left a comment
fmassa
left a comment
There was a problem hiding this comment.
LGTM, except for the test, which has a spurious assert now
| scriptable = False | ||
| msg = str(e) + str(tb) | ||
| self.assertEqual(torchub_models[name], scriptable, msg) | ||
| self.assertEqual(scriptable, scriptable, msg) |
There was a problem hiding this comment.
I'm not sure this change is what you want to do?
There was a problem hiding this comment.
Since they are all scriptable now, we don't need to access torchub_models and just assert that scriptable is True
There was a problem hiding this comment.
Can you then make
self.assertEqual(scriptable, True, msg)There was a problem hiding this comment.
oh oops - good catch
|
Test failures look legit |
|
@pytorchbot rebase this please |
…enet_scriptable
…enet_scriptable
Codecov Report
@@ Coverage Diff @@
## master #1349 +/- ##
==========================================
+ Coverage 63.9% 63.94% +0.03%
==========================================
Files 78 78
Lines 6147 6176 +29
Branches 940 944 +4
==========================================
+ Hits 3928 3949 +21
- Misses 1941 1947 +6
- Partials 278 280 +2
Continue to review full report at Codecov.
|
3 participants
Based on the conclusion from #1273: we are always returning a tuple when scripting.
This was blocked by pytorch/pytorch#26683.