Skip to content

Clean up and Document the io.image enhancements #3034

Closed
@datumbox

Description

@datumbox

PR #3024 introduced a few enhancements on the io.image methods used for reading JPEG and PNG images. The code changes were merged but there are a few nice-to-have improvements missing.

More specifically:

  • Provide better error messages for JPEG and PNG when a specific ImageReadMode value is not supported.
  • Ensure that image_read_mode.h has a new line at the end of the file.
  • Replace the old #define with the newer constexpr expression at image_read_mode.h.
  • Move the documentation of ImageReadMode values from the methods to the enum.

Note: constexpr might cause problems on Windows. If that's the case, try using const instead.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions