-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CONTRIBUTING.md #2651
Comments
Yes ! I was about to raise this Issue. Something in lines of ignite contribution file would be nice. Most might struggle to build docs, format code with linting etc. |
Yes, that is a great thing to have. I think we should clarify what are the criteria for adding new models / layers to torchvision, so that it's clear from the beginning. @vfdev-5 if you could start with a first, more generic, draft of the CONTRIBUTING file we could iterate on it Tagging @cpuhrsch @dongreenberg for thoughts. |
We could also reference the pytorch contribution guidelines with some additional torchvision specific guidance. |
TODO for this issue:
|
@vfdev-5 Just a suggestion. Perhaps add in the list that the CONTRIBUTING.md v1 was added and there are 2 more pendings. I would also put this on the top of the ticket instead of the comments so that it's visible and it's tracked by Github checklists. |
Thanks, I agree ! |
Let's close this issue and if needed open a specific one for new dataset addition |
🚀 Feature
It is a good practice to have CONTRIBUTING.md file to describe some guidelines for open-source contributions.
TODO:
cc @fmassa
The text was updated successfully, but these errors were encountered: