Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CONTRIBUTING.md #2663

Merged
merged 4 commits into from
Dec 9, 2020

Conversation

vfdev-5
Copy link
Collaborator

@vfdev-5 vfdev-5 commented Sep 10, 2020

Related #2651

Description:

  • Added a draft for CONTRIBUTING.md

This PR is not closing the issue #2651 as there are 2 sections to be defined later.

EDIT: There is already a PR submitted by the bot : #1564
I was not aware before.

@codecov
Copy link

codecov bot commented Sep 10, 2020

Codecov Report

Merging #2663 (8fb19e4) into master (ce34258) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2663   +/-   ##
=======================================
  Coverage   72.75%   72.75%           
=======================================
  Files          99       99           
  Lines        8979     8979           
  Branches     1431     1431           
=======================================
  Hits         6533     6533           
  Misses       1999     1999           
  Partials      447      447           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce34258...8fb19e4. Read the comment docs.

@datumbox
Copy link
Contributor

Any chance we could merge this to master? It's a good source of info for new comers as it describes setting up the dev environment. We could continue improving it post merge.

CONTRIBUTING.md Outdated Show resolved Hide resolved
@jgbradley1
Copy link
Contributor

This is just a suggestion. Should new datasets support at a minimum, the same constructor arguments (when appropriate)?

  • root
  • split
  • target_type
  • target_transform
  • transform
  • download - for large datasets that are unreasonable to download, should always raise a RuntimeError when download=True

@datumbox
Copy link
Contributor

@vfdev-5 @fmassa I really think we should merge this, even if there are a few things left to TBD. This doc contains useful information that will allow new contributors to learn how to build the library from source. What is the bare minimum we need to do to merge this?

@vfdev-5 vfdev-5 force-pushed the vfdev-5/issue-2651-contributing branch from dbc1f76 to c23b205 Compare December 4, 2020 13:51
@vfdev-5 vfdev-5 force-pushed the vfdev-5/issue-2651-contributing branch from ea71038 to 79a50f1 Compare December 4, 2020 14:04
@vfdev-5 vfdev-5 changed the title [WIP] Added CONTRIBUTING.md Added CONTRIBUTING.md Dec 4, 2020
Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for working on this @vfdev-5 !

Let's get this merged, and at the same time can you create an issue (or keep the existing one open) so that we track completing the points about datasets / models?

@fmassa
Copy link
Member

fmassa commented Dec 4, 2020

@jgbradley1 that's a good suggestion, although I'm not sure it can be generically implemented everywhere. FYI there was some discussion already in the past about dataset standardization in #1080

@vfdev-5
Copy link
Collaborator Author

vfdev-5 commented Dec 4, 2020

@fmassa let's keep existing issue open and I add a message about that.

@vfdev-5 vfdev-5 merged commit 4076a54 into pytorch:master Dec 9, 2020
facebook-github-bot pushed a commit that referenced this pull request Dec 10, 2020
Summary:
* [WIP] Added CONTRIBUTING.md

* Updated CONTRIBUTING.md

* Update

Reviewed By: fmassa

Differential Revision: D25460676

fbshipit-source-id: b28d9f5f2530363aa371b6ef7d09fa0cdb96bba9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants