Clarify label encoding comment in char_rnn_classification_tutorial #3658
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous comment 'Cache the tensor representation of the labels' was misleading, especially for beginners. The code actually creates a numerical representation by storing unique labels in alphabetical order and converting each label to its corresponding index as a tensor. Updated the comment to clearly explain what's happening: creating numerical representations rather than caching.
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/3658
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous comment 'Cache the tensor representation of the labels' was misleading, especially for beginners. The code actually creates a numerical representation by storing unique labels in alphabetical order and converting each label to its corresponding index as a tensor.
Updated the comment to clearly explain what's happening: creating numerical representations rather than caching.
Fixes #3646
Description
Checklist