Remove references to TorchScript in docs #3453
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gmagogsfm
commented
Jul 10, 2025
gmagogsfm
commented
- Removes references to TorchScript
- Replace it with a deprecation warning and redirect to torch.export when appropriate
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/3453
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
svekars
reviewed
Jul 11, 2025
| @@ -1,400 +0,0 @@ | |||
| """ | |||
| Introduction to TorchScript | |||
| =========================== | |||
There was a problem hiding this comment.
For all deleted files, please add an entry to https://github.com/pytorch/tutorials/blob/main/redirects.py
svekars
reviewed
Jul 11, 2025
| >>> print(torch.ops.my_ops.warp_perspective) | ||
| <built-in method custom::warp_perspective of PyCapsule object at 0x7ff51c5b7bd0> | ||
| TorchScript is deprecated, please use | ||
| `torch.export<https://docs.pytorch.org/tutorials/intermediate/torch_export_tutorial.html>`_ instead. |
There was a problem hiding this comment.
Please add an issue for all these pages with warning like this with the plan to delete them by {date} or {release}
|
Look like you have a build error: https://github.com/pytorch/tutorials/actions/runs/16257655203/job/45896761478?pr=3453 |
|
@svekars The warnings and redirect entries have been added. Can you pls review again? |
svekars
approved these changes
Jul 14, 2025
|
It looks good to me - thanks for creating the issue, too. |
svekars
reviewed
Jul 14, 2025
svekars
reviewed
Jul 14, 2025
svekars
reviewed
Jul 14, 2025
svekars
reviewed
Jul 14, 2025
svekars
added a commit
that referenced
this pull request
Jul 17, 2025
* Remove references to TorchScript in docs * Add missing todo and redirects --------- Co-authored-by: Svetlana Karslioglu <svekars@meta.com> Co-authored-by: Yiming Zhou <yimingzhou@meta.com>
angelayi
added a commit
that referenced
this pull request
Sep 10, 2025
Reverts part of #3453 which removed the Custom Class tutorial Custom classes are a generic concept in PyTorch. Although it was developed for TorchScript, it is also supported in Pytorch 2.0 as many users (like TensorRT and internal Ads frameworks) rely on it. Therefore, we should not delete this tutorial. Additionally the [Custom Class x PT2 tutorial](https://docs.pytorch.org/tutorials/advanced/custom_class_pt2.html) also references this tutorial, although CI did not seem to catch the broken link (cc @svekars) As part of revert, I removed references to TS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.