Skip to content

Update broken links tia index 3372 #3376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

nirajkamal
Copy link
Contributor

@nirajkamal nirajkamal commented Jun 3, 2025

Fixes #3372

Description

Errors in intermediate_source/tiatoolbox_tutorial.rst
[404] https://tia-toolbox.readthedocs.io/en/latest/usage.html?highlight=pretrained%20models#tiatoolbox.models.architecture.get_pretrained_model | Network error: Not Found
[404] https://tia-toolbox.readthedocs.io/en/latest/usage.html?highlight=WSIReader.read_rect#tiatoolbox.wsicore.wsireader.WSIReader.read_rect | Network error: Not Found
Errors in index.rst
[404] https://pytorch.org/executorch/stable/demo-apps-android.html | Network error: Not Found
[404] https://pytorch.org/executorch/stable/tutorials/sdk-integration-tutorial.html | Network error: Not Found
[404] https://pytorch.org/executorch/stable/demo-apps-ios.html | Network error: Not Found

Changes:

Location Old link [404] Working Link
intermediate_source/tiatoolbox_tutorial.rst https://tia-toolbox.readthedocs.io/en/latest/usage.html?highlight=pretrained%20models#tiatoolbox.models.architecture.get_pretrained_model https://tia-toolbox.readthedocs.io/en/stable/_autosummary/tiatoolbox.models.architecture.get_pretrained_model.html#tiatoolbox.models.architecture.get_pretrained_model
intermediate_source/tiatoolbox_tutorial.rst https://tia-toolbox.readthedocs.io/en/latest/usage.html?highlight=WSIReader.read_rect#tiatoolbox.wsicore.wsireader.WSIReader.read_rect https://tia-toolbox.readthedocs.io/en/stable/_autosummary/tiatoolbox.wsicore.wsireader.WSIReader.html#tiatoolbox.wsicore.wsireader.WSIReader.read_rect
Location Old link [404] Currently updated Working Link
index.rst https://pytorch.org/executorch/stable/demo-apps-android.html https://github.com/pytorch-labs/executorch-examples/tree/main/dl3/android/DeepLabV3Demo#executorch-android-demo-app
index.rst https://pytorch.org/executorch/stable/tutorials/sdk-integration-tutorial.html https://docs.pytorch.org/executorch/main/tutorials/devtools-integration-tutorial.html
index.rst https://pytorch.org/executorch/stable/demo-apps-ios.html https://github.com/pytorch-labs/executorch-examples/tree/main/mv3/apple/ExecuTorchDemo

Checklist

  • The issue that is being fixed is referred in the description (see above "Fixes Broken links detected in docs 🔗 #3372")
  • Only one issue is addressed in this pull request
  • Labels from the issue that this PR is fixing are added to this pull request
  • No unnecessary issues are included into this pull request.

cc - @spzala @svekars

cc @svekars @sekyondaMeta @AlannaBurke

Copy link

pytorch-bot bot commented Jun 3, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/3376

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit 9f9262b with merge base d627981 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@nirajkamal
Copy link
Contributor Author

nirajkamal commented Jun 3, 2025

The GitHub links are valid - but link checking fails maybe due to capcha.

Need suggestions weather to use links from 0.5 docs version instead. I have however seen the same GitHub links used in other parts of the documentation and hence used it in this PR.

Location Old link [404] Currently updated Working Link Working link from version 0.5
index.rst https://pytorch.org/executorch/stable/demo-apps-android.html (github) https://github.com/pytorch-labs/executorch-examples/tree/main/dl3/android/DeepLabV3Demo#executorch-android-demo-app https://docs.pytorch.org/executorch/0.5/demo-apps-android.html
index.rst https://pytorch.org/executorch/stable/tutorials/sdk-integration-tutorial.html https://docs.pytorch.org/executorch/main/tutorials/devtools-integration-tutorial.html  
index.rst https://pytorch.org/executorch/stable/demo-apps-ios.html (github) https://github.com/pytorch-labs/executorch-examples/tree/main/mv3/apple/ExecuTorchDemo https://docs.pytorch.org/executorch/0.5/demo-apps-ios.html

cc - @spzala @svekars

@sekyondaMeta
Copy link
Contributor

The GitHub links are valid - but link checking fails maybe due to capcha.

Need suggestions weather to use links from 0.5 docs version instead. I have however seen the same GitHub links used in other parts of the documentation and hence used it in this PR.

Location Old link [404] Currently updated Working Link Working link from version 0.5
index.rst https://pytorch.org/executorch/stable/demo-apps-android.html (github) https://github.com/pytorch-labs/executorch-examples/tree/main/dl3/android/DeepLabV3Demo#executorch-android-demo-app https://docs.pytorch.org/executorch/0.5/demo-apps-android.html
index.rst https://pytorch.org/executorch/stable/tutorials/sdk-integration-tutorial.html https://docs.pytorch.org/executorch/main/tutorials/devtools-integration-tutorial.html  
index.rst https://pytorch.org/executorch/stable/demo-apps-ios.html (github) https://github.com/pytorch-labs/executorch-examples/tree/main/mv3/apple/ExecuTorchDemo https://docs.pytorch.org/executorch/0.5/demo-apps-ios.html
cc - @spzala @svekars

Looks like the rest of the links are passing but one. Can you double check the one thats failing

@nirajkamal
Copy link
Contributor Author

nirajkamal commented Jun 3, 2025

The GitHub links are valid - but link checking fails maybe due to capcha.
Need suggestions weather to use links from 0.5 docs version instead. I have however seen the same GitHub links used in other parts of the documentation and hence used it in this PR.
Location Old link [404] Currently updated Working Link Working link from version 0.5
index.rst https://pytorch.org/executorch/stable/demo-apps-android.html (github) https://github.com/pytorch-labs/executorch-examples/tree/main/dl3/android/DeepLabV3Demo#executorch-android-demo-app https://docs.pytorch.org/executorch/0.5/demo-apps-android.html
index.rst https://pytorch.org/executorch/stable/tutorials/sdk-integration-tutorial.html https://docs.pytorch.org/executorch/main/tutorials/devtools-integration-tutorial.html  
index.rst https://pytorch.org/executorch/stable/demo-apps-ios.html (github) https://github.com/pytorch-labs/executorch-examples/tree/main/mv3/apple/ExecuTorchDemo https://docs.pytorch.org/executorch/0.5/demo-apps-ios.html
cc - @spzala @svekars

Looks like the rest of the links are passing but one. Can you double check the one thats failing

Found the issue - https://github.com/pytorch-labs/executorch-examples/tree/main/mv3/apple/ExecuTorchDemo in index.rst
@sekyondaMeta This link now works. The previous link is all lower case, it works in chrome but failed in safari - fixed it.

@nirajkamal
Copy link
Contributor Author

nirajkamal commented Jun 3, 2025

Fixed the GitHub link - it was due to case sensitivity while parsing the link in some browsers.

@sekyondaMeta sekyondaMeta merged commit 0353137 into pytorch:main Jun 4, 2025
20 checks passed
@nirajkamal nirajkamal deleted the Update_broken_links_tia_index_3372 branch June 4, 2025 15:44
@nirajkamal
Copy link
Contributor Author

Thank you @sekyondaMeta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken links detected in docs 🔗
3 participants