Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sharding tutorial for torchrec #1913

Merged
merged 4 commits into from
May 10, 2022
Merged

sharding tutorial for torchrec #1913

merged 4 commits into from
May 10, 2022

Conversation

YazhiGao
Copy link
Contributor

@YazhiGao YazhiGao commented May 6, 2022

This commit add the tutorial for exploring torchrec sharding for
distributed model parallelism for embedding tables in large scale deep
learning recommendation systems. We exploring the following sharding:

  • table-wise
  • row-wise
  • column-wise
  • data-parallel

@YazhiGao
Copy link
Contributor Author

YazhiGao commented May 6, 2022

@colin2328 @brianjo

@netlify
Copy link

netlify bot commented May 6, 2022

Deploy Preview for pytorch-tutorials-preview ready!

Name Link
🔨 Latest commit 5a39404
🔍 Latest deploy log https://app.netlify.com/sites/pytorch-tutorials-preview/deploys/627ac36c411fee000814b069
😎 Deploy Preview https://deploy-preview-1913--pytorch-tutorials-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@colin2328 colin2328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @YazhiGao !

This commit add the tutorial for exploring torchrec sharding for
distributed model parallelism for embedding tables in large scale deep
learning recommendation systems. We exploring the following sharding:
* table-wise
* row-wise
* column-wise
* data-parallel
Copy link
Contributor

@svekars svekars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A very minor tweak.

advanced_source/sharding.rst Outdated Show resolved Hide resolved
advanced_source/sharding.rst Outdated Show resolved Hide resolved
YazhiGao and others added 2 commits May 9, 2022 11:40
address comments

Co-authored-by: Svetlana Karslioglu <svekars@fb.com>
address issues

Co-authored-by: Svetlana Karslioglu <svekars@fb.com>
Copy link
Contributor

@colin2328 colin2328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@b0noI
Copy link
Contributor

b0noI commented May 10, 2022

@YazhiGao may I ask to:

  • rebase to the latest commit
  • update the PR

this will trigger CI again and hopefully this time jobs will run as expected

@svekars svekars merged commit ae74583 into pytorch:master May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants