Fixing timing scheme in cpp_extension tutorial #1851
Conversation
Print statement incorrectly stated `us` when it was in `100ms` units. For clarity I changed it to `s` units and removed the multiplication. This could have intended to be averaged but total time works just as well.
|
Hi @stevenwalton! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
✔️ Deploy Preview for pytorch-tutorials-preview ready! 🔨 Explore the source changes: fee1859 🔍 Inspect the deploy log: https://app.netlify.com/sites/pytorch-tutorials-preview/deploys/62284da5ef64b40007a2aecc 😎 Browse the preview: https://deploy-preview-1851--pytorch-tutorials-preview.netlify.app/advanced/cpp_extension |
`type()` is depreciated and it looks like `device()` is appropriate here. There are other `type` commands below and the error message says that `option` can be a drop-in but I'm unsure if this is appropriate for those calls.
|
Note here the second commit. I don't actually get warnings when compiling the code using |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
Hey @brianjo The "urllib.error.HTTPError: HTTP Error 500: Internal Server Error" error seems irrelevant to this PR. Shall we merge? |
|
Let me try to kick that worker first. :) |
Print statement incorrectly stated
uswhen it was in100msunits.For clarity I changed it to
sunits and removed the multiplication.This could have intended to be averaged but total time works just as
well.