Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use lint versions from dev-requirements.txt #719

Merged
merged 1 commit into from
Apr 3, 2023
Merged

Conversation

d4l3k
Copy link
Member

@d4l3k d4l3k commented Apr 1, 2023

Previously we specified lint dependencies in two locations that didn't match. This makes CI use the versions from dev-requirements.txt.

It also runs black on all files with the latest version.

Test plan:

scripts/lint.sh

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 1, 2023
@codecov
Copy link

codecov bot commented Apr 1, 2023

Codecov Report

Merging #719 (def605d) into main (65ed0fd) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #719   +/-   ##
=======================================
  Coverage   92.98%   92.98%           
=======================================
  Files          91       91           
  Lines        6000     6000           
=======================================
  Hits         5579     5579           
  Misses        421      421           
Impacted Files Coverage Δ
torchx/cli/cmd_configure.py 100.00% <ø> (ø)
torchx/schedulers/ray_scheduler.py 95.29% <ø> (ø)
torchx/schedulers/test/train.py 0.00% <ø> (ø)
torchx/version.py 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@d4l3k d4l3k force-pushed the lint-requirements branch from b9ff37b to def605d Compare April 3, 2023 20:14
@d4l3k d4l3k merged commit 8179e22 into main Apr 3, 2023
@d4l3k d4l3k deleted the lint-requirements branch April 3, 2023 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants