(torchx/specs) Support builtin list[str] and dict[str, str] runopts opt_type #1090
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pt_type
Summary:
For python-3.9+ support scheduler runopt types to be specified using the built-in generic types (e.g. `list[str]` over `typing.List[str]`).
Basically lets scheduler implementations to declare their runopts (cfg) as:
```
def _run_opts(self) -> runopts:
opts = runopts()
opts.add("regions", type_=list[str], help="a list opt", default=[])
opts.add("envs", type_=dict[str, str], help="a dict opt", default=[])
```
versus having to do:
```
from typing import List, Dict
def _run_opts(self) -> runopts:
opts = runopts()
opts.add("regions", type_=List[str], help="a list opt", default=[])
opts.add("envs", type_=Dict[str, str], help="a dict opt", default=[])
```
Differential Revision: D78444106
meta-cla
bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D78444106 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
For python-3.9+ support scheduler runopt types to be specified using the built-in generic types (e.g.
list[str]overtyping.List[str]).Basically lets scheduler implementations to declare their runopts (cfg) as:
versus having to do:
Differential Revision: D78444106