Skip to content

gemma2 had wrong path to scheduler #2013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 15, 2024
Merged

gemma2 had wrong path to scheduler #2013

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2bb38f5
update configs
Nov 15, 2024
6860282
delete deprecated module
Nov 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion recipes/configs/gemma2/27B_lora.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ optimizer:
lr: 2e-5

lr_scheduler:
_component_: torchtune.modules.get_cosine_schedule_with_warmup
_component_: torchtune.training.lr_schedulers.get_cosine_schedule_with_warmup
num_warmup_steps: 10

loss:
Expand Down
2 changes: 1 addition & 1 deletion recipes/configs/gemma2/27B_lora_single_device.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ optimizer:
lr: 5e-5

lr_scheduler:
_component_: torchtune.modules.get_cosine_schedule_with_warmup
_component_: torchtune.training.lr_schedulers.get_cosine_schedule_with_warmup
num_warmup_steps: 10

loss:
Expand Down
2 changes: 1 addition & 1 deletion recipes/configs/gemma2/27B_qlora_single_device.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ optimizer:
lr: 2e-5

lr_scheduler:
_component_: torchtune.modules.get_cosine_schedule_with_warmup
_component_: torchtune.training.lr_schedulers.get_cosine_schedule_with_warmup
num_warmup_steps: 10

loss:
Expand Down
2 changes: 1 addition & 1 deletion recipes/configs/gemma2/2B_lora.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ optimizer:
lr: 2e-5

lr_scheduler:
_component_: torchtune.modules.get_cosine_schedule_with_warmup
_component_: torchtune.training.lr_schedulers.get_cosine_schedule_with_warmup
num_warmup_steps: 10

loss:
Expand Down
2 changes: 1 addition & 1 deletion recipes/configs/gemma2/2B_lora_single_device.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ optimizer:
lr: 2e-5

lr_scheduler:
_component_: torchtune.modules.get_cosine_schedule_with_warmup
_component_: torchtune.training.lr_schedulers.get_cosine_schedule_with_warmup
num_warmup_steps: 10

loss:
Expand Down
2 changes: 1 addition & 1 deletion recipes/configs/gemma2/2B_qlora_single_device.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ optimizer:
lr: 2e-5

lr_scheduler:
_component_: torchtune.modules.get_cosine_schedule_with_warmup
_component_: torchtune.training.lr_schedulers.get_cosine_schedule_with_warmup
num_warmup_steps: 10

loss:
Expand Down
2 changes: 1 addition & 1 deletion recipes/configs/gemma2/9B_lora.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ optimizer:
lr: 2e-5

lr_scheduler:
_component_: torchtune.modules.get_cosine_schedule_with_warmup
_component_: torchtune.training.lr_schedulers.get_cosine_schedule_with_warmup
num_warmup_steps: 10

loss:
Expand Down
2 changes: 1 addition & 1 deletion recipes/configs/gemma2/9B_lora_single_device.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ optimizer:
lr: 5e-5

lr_scheduler:
_component_: torchtune.modules.get_cosine_schedule_with_warmup
_component_: torchtune.training.lr_schedulers.get_cosine_schedule_with_warmup
num_warmup_steps: 10

loss:
Expand Down
2 changes: 1 addition & 1 deletion recipes/configs/gemma2/9B_qlora_single_device.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ optimizer:
lr: 2e-5

lr_scheduler:
_component_: torchtune.modules.get_cosine_schedule_with_warmup
_component_: torchtune.training.lr_schedulers.get_cosine_schedule_with_warmup
num_warmup_steps: 10

loss:
Expand Down
2 changes: 1 addition & 1 deletion recipes/configs/qwen2/knowledge_distillation_distributed.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ optimizer:
weight_decay: 0.01
lr: 3e-4
lr_scheduler:
_component_: torchtune.modules.get_cosine_schedule_with_warmup
_component_: torchtune.training.lr_schedulers.get_cosine_schedule_with_warmup
num_warmup_steps: 100

loss:
Expand Down
2 changes: 0 additions & 2 deletions torchtune/modules/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
from .kv_cache import KVCache # noqa
from .layer_norm import Fp32LayerNorm # noqa
from .low_precision import FrozenNF4Linear # noqa
from .lr_schedulers import get_cosine_schedule_with_warmup # noqa
from .position_embeddings import RotaryPositionalEmbeddings # noqa
from .rms_norm import RMSNorm # noqa
from .tanh_gate import TanhGate # noqa
Expand Down Expand Up @@ -50,5 +49,4 @@
"local_kv_cache",
"delete_kv_caches",
"disable_kv_cache",
"get_cosine_schedule_with_warmup",
]
61 changes: 0 additions & 61 deletions torchtune/modules/lr_schedulers.py
View file
Open in desktop

This file was deleted.

Loading