Make AlpacaToMessage public.

[krammnic]

Context

What is the purpose of this PR? Is it to

• add a new feature
• fix a bug
• update tests and/or documentation
• other (please add here)

Please link to any issues this PR addresses.

Changelog

What are the changes made in this PR?

• Make AlpacaToMessage public.
  Make AlpacaToMessages public #1769

Test plan

Please make sure to do each of the following if applicable to your PR. If you're unsure about any one of these just ask and we will happily help. We also have a contributing page for some guidance on contributing.

• run pre-commit hooks and linters (make sure you've first installed via pre-commit install)
• add unit tests for any new functionality
• update docstrings for any new or updated methods or classes
• run unit tests via pytest tests
• run recipe tests via pytest tests -m integration_test
• manually run any new or modified recipes with sufficient proof of correctness
• include relevant commands and any other artifacts in this summary (pastes of loss curves, eval results, etc.)

UX

If your function changed a public API, please add a dummy example of what the user experience will look like when calling it.
Here is a docstring example
and a tutorial example

• I did not change any public API
• I have added an example to docs or docstrings

Really minor fix. This code is now working:

from torchtune.datasets import AlpacaToMessages

message_transform = AlpacaToMessages(
    train_on_input=True, column_map=None
)

[pytorch-bot]

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/1785

• 📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 143a348 with merge base 54673b7 ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[krammnic]

@joecummings @RdoubleA Require review. Really minor fix, provided reproducible example.

[joecummings]

Thanks for this!

[krammnic]

Oh, some strange problem with docs, let me fix

[krammnic]

I see, should have added in data/__init__.py

[krammnic]

@joecummings I found out the problem. AlpacaToMessages should be moved to torchtune.data by analogy to other Transforms, it should not be included in datasets if it is public(I don't know how it happened that it is not with other transforms but in alpaca_dataset).

[joecummings]

@joecummings I found out the problem. AlpacaToMessages should be moved to torchtune.data by analogy to other Transforms, it should no be included in datasets if it is public(I don't know how it happened that it is not with other transforms but in alpaca_dataset).

cc @RdoubleA - where do you want AlpacaToMessages to live?

[RdoubleA]

@krammnic @joecummings thanks for pointing this out. Let's move AlpacaToMessages to torchtune/data/_messages.py where the other message transforms live.

[krammnic]

New example, if changing API:

from torchtune.data._messages import AlpacaToMessages

message_transform = AlpacaToMessages(
    train_on_input=True, column_map=None
)

We probably can don't care about legacy, because previously it was internal.

[krammnic]

@joecummings @RdoubleA You can check new changes

[RdoubleA]

Docs look good. just need to fix lint by running: pre-commit run --all-files

[krammnic]

Docs look good. just need to fix lint by running: pre-commit run --all-files

Runned it and pushed. I hope now is fine.

[krammnic]

Probably can be merged, all checks passed.