Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aoti #1753

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Aoti #1753

wants to merge 3 commits into from

Conversation

larryliu0820
Copy link

Context

What is the purpose of this PR? Is it to

  • add a new feature
  • fix a bug
  • update tests and/or documentation
  • other (please add here)

Please link to any issues this PR addresses.

Changelog

What are the changes made in this PR?
*

Test plan

Please make sure to do each of the following if applicable to your PR. If you're unsure about any one of these just ask and we will happily help. We also have a contributing page for some guidance on contributing.

  • run pre-commit hooks and linters (make sure you've first installed via pre-commit install)
  • add unit tests for any new functionality
  • update docstrings for any new or updated methods or classes
  • run unit tests via pytest tests
  • run recipe tests via pytest tests -m integration_test
  • manually run any new or modified recipes with sufficient proof of correctness
  • include relevant commands and any other artifacts in this summary (pastes of loss curves, eval results, etc.)

UX

If your function changed a public API, please add a dummy example of what the user experience will look like when calling it.
Here is a docstring example
and a tutorial example

  • I did not change any public API
  • I have added an example to docs or docstrings

tarun292 and others added 2 commits September 24, 2024 15:09
Summary: Download artifacts from https://www.internalfb.com/manifold/explorer/executorch/tree/models/llama/llama3_2_mm_v4

* dog.jpg
* tune.pth

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
Copy link

pytorch-bot bot commented Oct 4, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/1753

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 4, 2024
@larryliu0820
Copy link
Author

Download artifacts from https://www.internalfb.com/manifold/explorer/executorch/tree/models/llama/llama3_2_mm_v4

  • tune.pth
  • dog.jpg

To a directory say llama3_2_mm_v4/

Then run python export_flamingo.py llama3_2_mm_v4/.

Copy link
Contributor

@ebsmothers ebsmothers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @larryliu0820 can you give more context on this PR? As is I don't think we want to land this, though can't tell if it's still WIP. If you can share more details on the motivation and plans here that'd be helpful.

@larryliu0820 larryliu0820 marked this pull request as draft October 9, 2024 06:27
@larryliu0820
Copy link
Author

Hi @ebsmothers thanks for asking. This is all the changes required to export llama 3.2 MM 11B using torch.aot_compile() or AOT inductor. I sent this out so we can work with PyTorch compiler folks to debug together. Most of the changes will live outside of torchtune and I'll send separate PRs if I think some of the changes should live in torchtune repo.

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants