Switch to json for snapshot metadata #120
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D40626156 |
Codecov Report
@@ Coverage Diff @@
## main #120 +/- ##
==========================================
- Coverage 91.80% 86.98% -4.82%
==========================================
Files 31 31
Lines 2550 2551 +1
==========================================
- Hits 2341 2219 -122
- Misses 209 332 +123
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
yifuwang
pushed a commit
to yifuwang/torchsnapshot
that referenced
this pull request
Oct 25, 2022
Summary: Pull Request resolved: pytorch#120 When the number of entries in the snapshot metadata is very large, yaml serialization becomes a bottleneck and there's little we can do to optimize. Fortunately, when the metadata is serialized via json it is still valid yaml. Technically, the snapshot metadata format is still yaml. Reviewed By: raypeng Differential Revision: D40626156 fbshipit-source-id: 3651ad082733f5c52a42cb3df7080d71cdcec268
|
This pull request was exported from Phabricator. Differential Revision: D40626156 |
yifuwang
force-pushed
the
export-D40626156
branch
from
a037b62 to
a831b95
Compare
Summary: Pull Request resolved: pytorch#120 When the number of entries in the snapshot metadata is very large, yaml serialization becomes a bottleneck and there's little we can do to optimize. Fortunately, when the metadata is serialized via json it is still valid yaml. Technically, the snapshot metadata format is still yaml. Reviewed By: raypeng Differential Revision: D40626156 fbshipit-source-id: e264ad8f37335b8d7565dbf762a567c1007551a7
yifuwang
force-pushed
the
export-D40626156
branch
from
a831b95 to
c51d92b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D40626156 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
When the number of entries in the snapshot metadata is very large, yaml
serialization becomes a bottleneck and there's little we can do to optimize.
Fortunately, when the metadata is serialized via json it is still valid yaml.
Technically, the snapshot metadata format is still yaml.
Reviewed By: raypeng
Differential Revision: D40626156