refactor planner to use device_type #8
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: refactor the planner to take only planner type as we want to decouple plan and DMP callsites for GPU inference Reviewed By: divchenko Differential Revision: D31588920 fbshipit-source-id: 74e100818171c55d67b091676552a4d53e102ca4
|
This pull request was exported from Phabricator. Differential Revision: D31588920 |
facebook-github-bot
added
the
CLA Signed
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 16, 2021
Summary: Pull Request resolved: #8 refactor the planner to take only planner type as we want to decouple plan and DMP callsites for GPU inference Reviewed By: divchenko Differential Revision: D31588920 fbshipit-source-id: 965fbe80ae734fdd9f59153f291ac3e34c14f4e8
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 10, 2022
Summary: Pull Request resolved: #8 Static graph is now part of DDP constructor, so migrate the callsite away from the private API which will eventually be deprecated. Question regarding OSS side: Since this is dependent on a recently landed pytorch change, do we need to gate this code based on PT version or does TRec use latest pytorch? Reviewed By: divchenko Differential Revision: D34045294 fbshipit-source-id: 7751eb37a4ab66b2ca19deda5e527c6043522f46
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: refactor the planner to take only planner type as we want to decouple plan and DMP callsites for GPU inference
Reviewed By: divchenko
Differential Revision: D31588920