Modify torchrec code to use reduce_scatter_v and all_gather_v #580
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h#568) Summary: Pull Request resolved: pytorch#568 This change adds a new `PooledEmbeddingsReduceScatterV` which uses `_reduce_scatter_v` and `_all_gather_v` in c10d for performing row-wise and table-wise row-wise sharding. Reviewed By: YazhiGao Differential Revision: D37735264 fbshipit-source-id: 8b5b7830f180a757a42fa3db0cfbc33ec962ae92
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D37735264 |
aashaka
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This change adds a new
PooledEmbeddingsReduceScatterVwhich uses_reduce_scatter_vand_all_gather_vin c10d for performing row-wise and table-wise row-wise sharding.Reviewed By: YazhiGao
Differential Revision: D37735264